-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stage url update #2056
stage url update #2056
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2056.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c91ql2oivq0682umsrg0. |
Your Render PR Server URL is https://files-ui-stage-pr-2056.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c91ql40ivq0682umsrkg. |
Your Render PR Server URL is https://storage-ui-stage-pr-2056.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c91ql50ivq0682umss60. |
I noticed after the URL change that I had to recreate some accounts to fix some failing tests, the accounts being used for lookups no longer existed and none of the share links were valid either. I'm not sure if that was expected after the url switch so I'm leaving this as a draft, maybe this data update was unnecessary? There are also some legitimate test fails still happening due to the Max plan not being returned in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, having some cors error now, but the changes look good.
There was an env set for the github action with the old url. I removed this and it should be fine now. |
many tests are failing.. can't tell why, it seems random.. |
@Tbaut Yeah I think it's maybe because the data update - seems like original data was put back since I made the changes and now the new data I created yesterday was wiped. I will try reverting those changes and re-test soon. |
@FSM1 @Tbaut @tanmoyAtb As expected, I had to revert the data changes I made because the old data returned and the new stuff I had created no longer existed 🙃 The only failures happening now in this branch are related to issues raised on our channel
Hopefully, once those issues are fixed we can merge this into dev, and then we can update all of the other PRs to bring in these changes. |
Tbh I'd merge. This will be one pr less. If there's anything we can do later, let's do it in another one. |
Sounds good :) |
Replace references of
https://stage.imploy.site/api/v1
withhttps://stage-api.chainsafe.io/api/v1
+ update tests